On-demand analysis of past recordings #62
Conversation
wgreenberg
commented
Oct 3, 2024
wgreenberg
commented
- rayhunter-daemon: API for triggering and reading analysis
- rayhunter-daemon: rename readonly mode to debug mode
- rayhunter-daemon: debug mode allows live-loading frontend files
- rayhunter-check: rework to handle directories
- rayhunter-check: better output
- CI: build rayhunter-check
* rayhunter-daemon: API for triggering and reading analysis * rayhunter-daemon: rename readonly mode to debug mode * rayhunter-daemon: debug mode allows live-loading frontend files * rayhunter-check: rework to handle directories * rayhunter-check: better output * CI: build rayhunter-check
bin/src/config.rs
Outdated
There was a problem hiding this comment.
I think having debug mode and also a debug flag in the compiler is redundant and perhaps a bit confusing? I think we should stick with one or the other.
There was a problem hiding this comment.
Looking at the rest of the code I think it makes sense to have these as two separate things. But maybe debug mode isn't the right thing to call this one? It's more like no diag mode? or server only mode?
There was a problem hiding this comment.
This is a nit I think and does not need to be fixed before merging.
| if (row["analysis"]) { | ||
| const timestamp = new Date(row["timestamp"]); | ||
| const analysis = row["analysis"]; | ||
| for (const warning of analysis) { |
There was a problem hiding this comment.
we should also update the row class here to be tr.warning
dist/config.toml.example
Outdated
There was a problem hiding this comment.
If we are going to have debug_mode be a config option I think we should have it in the example config. We should at least have a comment explaining what it does though. Unless you think it's enough of a footgun that we shouldn't even put it in there?
Also consolidate the duplicate AnalysisWriter implementation
